Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators do not work inside function call inside macros #352

Closed
adienes opened this issue Jan 18, 2023 · 3 comments
Closed

operators do not work inside function call inside macros #352

adienes opened this issue Jan 18, 2023 · 3 comments

Comments

@adienes
Copy link

adienes commented Jan 18, 2023

Saw this on Discourse, just wanted to make sure it got flagged in an issue.

julia> df = DataFrame((; a=[1,2,3], b=[4,5,6], x=[1,1,2]));

julia> group = groupby(df, [:x]);

julia> @combine(group, :z = sum(:a .* :b)) #BREAKS
ERROR: UndefVarError: `.*` not defined

julia> @combine(group, :z = (:a .* :b) |> sum) #works
julia> @combine(group, :z = sum(max.(:a, :b))) #also works
@bkamins
Copy link
Member

bkamins commented Jan 18, 2023

This is fixed on master. It will be included in the next release. For the mean time add #master instead of latest release to your project.

@bkamins bkamins closed this as completed Jan 18, 2023
@adienes
Copy link
Author

adienes commented Jan 18, 2023

awesome, sorry for the noise

@bkamins
Copy link
Member

bkamins commented Jan 18, 2023

No problem - it is important to get some feedback, so that @pdeffebach pushes for the release 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants