Skip to content
This repository has been archived by the owner on May 5, 2019. It is now read-only.

duplicate functionality in merge! and hcat! #52

Open
cjprybol opened this issue Apr 12, 2017 · 2 comments · May be fixed by #70
Open

duplicate functionality in merge! and hcat! #52

cjprybol opened this issue Apr 12, 2017 · 2 comments · May be fixed by #70

Comments

@cjprybol
Copy link
Contributor

AFAICT merge! and hcat! do the same thing. Should we export hcat! and deprecate merge!?

@ararslan
Copy link
Member

If anything I would do it the other way around: keep merge!, since that's the familiar name for this operation, and deprecate hcat!, since that's more reminiscent of Julia matrix terminology.

@cjprybol
Copy link
Contributor Author

Sounds good to me! It's also easier to change the internal function names than it is to change all the code out in the wild that uses merge!. When I open the PR for this I'll add something to the docs to help users choose between hcat, merge!, and full outer join which all allow users to merge tables but do so in different ways. I just found out about merge! while reviewing tests for the #30 refactor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants