Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for downstream packages #135

Closed
nickrobinson251 opened this issue Oct 12, 2022 · 2 comments
Closed

Add Integration Tests for downstream packages #135

nickrobinson251 opened this issue Oct 12, 2022 · 2 comments

Comments

@nickrobinson251
Copy link
Collaborator

Such as InlineStrings.jl, CSV.jl, ...

To avoid issues like #133

We could use a GitHub Action workflow like https://github.com/JuliaDiff/ChainRulesCore.jl/blob/v1.15.6/.github/workflows/IntegrationTest.yml

@quinnj
Copy link
Member

quinnj commented Oct 12, 2022

Hmmmm.....maybe. I think we should make the Parsers interfaces much more well-defined and strict/robust, which is a big part of the aim in #127; I think if we have more solid user-facing overload functions, we avoid lots of scenarios where we accidentally break things by doing little tweaks.

But if it's not too much overhead/burden, I'm not opposed to doing downstream tests.

@quinnj
Copy link
Member

quinnj commented Oct 25, 2022

Added by @nickrobinson251 in #137; thanks!

@quinnj quinnj closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants