expand ~ when opening files

[haakon-e]

Would you be open to modifying

YAML.jl/src/YAML.jl

Lines 94 to 102 in 844ad27

	load_file(filename::AbstractString, args...; kwargs...) =
	open(filename, "r") do input
	load(input, args...; kwargs...)
	end
	load_all_file(filename::AbstractString, args...; kwargs...) =
	open(filename, "r") do input
	load_all(input, args...; kwargs...)
	end

to allow for data = YAML.load_file("~/test.yml") to "just work"?

I think it would simply be:

load_file(filename::AbstractString, args...; kwargs...) =
    open(expanduser(filename), "r") do input
        load(input, args...; kwargs...)
    end

load_all_file(filename::AbstractString, args...; kwargs...) =
    open(expanduser(filename), "r") do input
        load_all(input, args...; kwargs...)
    end

Current behavior:

julia> data = YAML.load_file("~/test.yml")
ERROR: SystemError: opening file "~/test.yml": No such file or directory
Stacktrace:
      ⋮ internal @ Base, Unknown
  [9] load_file(::String)
    @ YAML ~/.julia/packages/YAML/U6OOW/src/YAML.jl:94
Use `err` to retrieve the full stack trace.

julia> data = YAML.load_file(expanduser("~/test.yml"))
Dict{Any, Any} with 7 entries:
  "receipt"         => "Oz-Ware Purchase Invoice"
  "items"           => Dict{Any, Any}[Dict("part_no"=>"A4786", "price"=>1.47, "descrip"=>"Water Bucket (Filled)", "quantity"…
  "customer"        => Dict{Any, Any}("given"=>"Dorothy", "family"=>"Gale")
  "ship-to"         => Dict{Any, Any}("city"=>"East Centerville", "street"=>"123 Tornado Alley\nSuite 16\n", "state"=>"KS")
  "bill-to"         => Dict{Any, Any}("city"=>"East Centerville", "street"=>"123 Tornado Alley\nSuite 16\n", "state"=>"KS")
  "specialDelivery" => "Follow the Yellow Brick Road to the Emerald City. Pay no attention to the man behind the curtain."
  "date"            => Date("2012-08-06")

[kescobo]

This is true in most (all?) julia functions that take strings as paths. While I agree this is inconvenient, and it frequently bites me, I'd be reluctant to change something that's so common across the language in just this package.

[kescobo]

One thing that might be worth an issue or PR (though I think it would go into julia itself) would be to improve the error message to mention the use or normpath() and expanduser() if someone hits that system error

[haakon-e]

Thanks. It seems like this is on the way to being addressed (at least through more helpful error messages) in newer versions of Julia. Looking through past issues in the Julia repo, there seems to be some justification for not "fixing" this.

[kescobo]

Great! Thanks for engaging and being part of the solution!