Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log1p getting overwritten #14

Closed
ExpandingMan opened this issue Jun 18, 2018 · 2 comments
Closed

log1p getting overwritten #14

ExpandingMan opened this issue Jun 18, 2018 · 2 comments

Comments

@ExpandingMan
Copy link
Contributor

There seems to be an extra method from another library here. At least on 0.7 this results in the methods for log1p getting overwritten. Would it be ok to either delete this line or, if it's needed for 0.6, move it to within the conditional?

@jrevels
Copy link
Member

jrevels commented Jun 19, 2018

Yes, we should just wrap it in a conditional e.g.

if is_version_that_doesnt_need_to_reference_libm(VERSION)
    @define_diffrule Base.log1p(x) = ...
else
    @define_diffrule Base.Math.JuliaLibm.log1p(x) = ...
end

I don't know what that predicate is off the top of my head, but it seems like just Base.log1p works for v0.7.

@jrevels
Copy link
Member

jrevels commented Jun 20, 2018

closed by #15

@jrevels jrevels closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants