-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jacobian!
#88
Comments
This version is even faster: function jacobian!{T<:Number}(jjac::Array{T,2}, vf::Array{TaylorN{T},1})
numVars = get_numvars()
@assert length(vf) == numVars
for comp2 = 1:numVars
for comp1 = 1:numVars
jjac[comp1,comp2] = vf[comp1].coeffs[2].coeffs[comp2]
end
end
nothing
end Edit: I was messing with the indices, now it should work fine |
Can you send a PR, with tests? I'm actually spending some time in this kind of tricks... |
Regarding #87, if you are in a hurry, just send it using the current master. |
PR #91 is an attempt to implement inplace evaluation versions of |
Closed by PR #91 |
Done it, though not in a clean way; you'll have to |
... on that branch |
Related to TaylorIntegration's PR #18. For performance reasons, it would be good to have an in-place evaluation version of
jacobian
in TaylorSeries. My proposal is something like this:As far as I've tested it, this change improves memory use on TaylorIntegration Lyapunov spectrum methods, in particular
stabilitymatrix!
, wherejacobian
is currently used.. Perhaps this could be included in #87 ?The text was updated successfully, but these errors were encountered: