Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Δt to dt #16

Merged
merged 2 commits into from Nov 28, 2019
Merged

Δt to dt #16

merged 2 commits into from Nov 28, 2019

Conversation

ChrisRackauckas
Copy link
Member

Allows for non-unicode interface. Otherwise the package will not work on terminals and clusters which don't support unicode, which is a sad reason for a package to not work. Thus in general, it's okay for unicode to be used internally, but there shouldn't be a user-facing requirement to use unicode (like a keyword argument)

Allows for non-unicode interface
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #16 into master will increase coverage by 0.77%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   75.96%   76.74%   +0.77%     
==========================================
  Files           5        5              
  Lines         129      172      +43     
==========================================
+ Hits           98      132      +34     
- Misses         31       40       +9
Impacted Files Coverage Δ
src/extended_dmd.jl 76.08% <66.66%> (-0.84%) ⬇️
src/exact_dmd.jl 67.79% <75%> (+9.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d35054...2fd4410. Read the comment docs.

Copy link
Collaborator

@AlCap23 AlCap23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't think about that 👍

I added some slight changes. We require dt to be positive ( or zero ) and any type of <: Real.

@AlCap23 AlCap23 merged commit d19515a into master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants