Add Pareto Front Identification for SINDY #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit sindy
1) Function `unique` inside the Basis constructor was never being called because the argument's type was AbstractVector{Operation} instead of a Basis.
2) Using simplify_constants since `isequal` was considering things like 1u[1]^1 equal to u[1].
Wrong norm
Wrong Norm
Simply sets the threshold an collects the basis
nicer print, push!, merge, count ops and free parameters
Hankel, AIC, BIC, optimal threshold
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 13 13
Lines 389 389
=======================================
Hits 341 341
Misses 48 48
Continue to review full report at Codecov.
|
Last tweaks for SR3; works fine now.
With qr
y was not defined so just change it for some fixed parameters
AlCap23
changed the title
This was referenced Feb 9, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also merges #29 , since we need most of the model selection criteria.