Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reinit #53

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Implement reinit #53

merged 1 commit into from
Nov 6, 2017

Conversation

devmotion
Copy link
Member

This PR is based on #49 and implements reinit! for DDEIntegrator.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 82.528% when pulling 63bde02 on devmotion:reinit2 into 67bd419 on JuliaDiffEq:master.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #53 into master will increase coverage by 0.39%.
The diff coverage is 74.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   82.12%   82.52%   +0.39%     
==========================================
  Files          11       11              
  Lines         498      538      +40     
==========================================
+ Hits          409      444      +35     
- Misses         89       94       +5
Impacted Files Coverage Δ
src/solve.jl 81.88% <64.28%> (+1.12%) ⬆️
src/integrator_interface.jl 67.2% <83.72%> (+8.66%) ⬆️
src/callbacks.jl 89.18% <0%> (-1.36%) ⬇️
src/discontinuity_type.jl 52.94% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bd419...63bde02. Read the comment docs.

@ChrisRackauckas
Copy link
Member

Thanks for finishing this up. Looks great.

@ChrisRackauckas ChrisRackauckas merged commit 085d714 into SciML:master Nov 6, 2017
@devmotion devmotion deleted the reinit2 branch November 6, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants