Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turing inference #48

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Conversation

xukai92
Copy link
Contributor

@xukai92 xukai92 commented Jun 25, 2018

Resolve #46

@xukai92
Copy link
Contributor Author

xukai92 commented Jun 25, 2018

The test for Turing.jl doesn't pass because of the adaptation issue in Turing.jl, which should be solved after the current PR I'm working on is merged (TuringLang/Turing.jl#436).

@xukai92
Copy link
Contributor Author

xukai92 commented Jul 3, 2018

My Turing.jl PR was just merged and I made a new release. But it seems that the new version cannot be fetched. Should I do something else or it's a problem of time?

@ChrisRackauckas
Copy link
Member

A tag was never sent to METADATA: https://github.com/JuliaLang/METADATA.jl/pulls?utf8=%E2%9C%93&q=Turing

@xukai92
Copy link
Contributor Author

xukai92 commented Jul 3, 2018

It is because of the change of URL?

@ChrisRackauckas
Copy link
Member

Attobot probably wasn't enabled in the new org.

@xukai92
Copy link
Contributor Author

xukai92 commented Jul 4, 2018

It's in the METADATA PR list now. @ChrisRackauckas

@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #48 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #48     +/-   ##
=========================================
- Coverage   89.62%   89.43%   -0.2%     
=========================================
  Files           6        6             
  Lines         241      246      +5     
=========================================
+ Hits          216      220      +4     
- Misses         25       26      +1
Impacted Files Coverage Δ
src/turing_inference.jl 100% <100%> (ø) ⬆️
src/dynamichmc_inference.jl 94.44% <0%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4949ec4...df81743. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 8e9548f into SciML:master Jul 4, 2018
@ChrisRackauckas
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants