Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only require 1.0 #151

Merged
merged 3 commits into from Sep 14, 2019
Merged

only require 1.0 #151

merged 3 commits into from Sep 14, 2019

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@isaacsas
Copy link
Member

Is this going to cause isnothing issues? That's 1.1 only right?

@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files           9        9           
  Lines         962      962           
=======================================
  Hits          900      900           
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ac279...650a49c. Read the comment docs.

@ChrisRackauckas
Copy link
Member Author

I think we just need to add Compat for it. FWIW, this is now the last blocker for DifferentialEquations.jl to work on v1.1 again, so I'm going to try and find out what it needs and then we'll be fully compatible again.

@ChrisRackauckas
Copy link
Member Author

The /pr passes but /push didn't, so maybe something weird happened but it's good enough to know it's likely not a versioning thing.

@ChrisRackauckas ChrisRackauckas merged commit e29d36e into master Sep 14, 2019
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-2 branch September 14, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants