New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dp errors #153
Fix dp errors #153
Conversation
Okay, I've investigated this error quite closely. Basically it works fine on Julia 1.1 and above, but errors on Julia 1.0. The reasons for this seems to sit quite deep, and partially due to behaviours in Either we let this PR rest until we make DiffEqBiological require a later Julia version (1.1). However, I do think this change is somewhat important for bifurcation analysis, so the rest time should not get too long. Or I make some slight modification to the test, making them a bit less strong, so the 1.0 errors slip by (they are not that serious. Basically some paths are added twice to the diagram. However, when they are plotted the identical paths overlap and the plot itself is not different. There might be a problem if someone uses the bifurcation diagram objects for non-visual purposes) |
I'm fine with requiring 1.1 and up, but I think @ChrisRackauckas was having problems somewhere else that had required us to still support 1.0. Maybe he can chime in. We could make a major version number increment to indicate 1.1 is now required. |
It blocks the DifferentialEquations.jl tests. Maybe put an if statement on the bifurcation tests and only run them if >= v"1.1" and otherwise throw a warning that those are disabled on 1.0? |
That's sounds like a good solution. |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 93.65% 93.77% +0.11%
==========================================
Files 9 9
Lines 962 964 +2
==========================================
+ Hits 901 904 +3
+ Misses 61 60 -1
Continue to review full report at Codecov.
|
Co-Authored-By: Christopher Rackauckas <Contact@ChrisRackauckas.com>
Co-Authored-By: Christopher Rackauckas <Contact@ChrisRackauckas.com>
Co-Authored-By: Christopher Rackauckas <Contact@ChrisRackauckas.com>
Co-Authored-By: Christopher Rackauckas <Contact@ChrisRackauckas.com>
While preparing a short tutorial for making bifurcation diagrams I actually discovered an error where some paths were not displayed correctly. It was basically due to be mixing up some parameters in the heuristics. Should be sorted now.