Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autodifferentiation #16

Merged
merged 1 commit into from Aug 25, 2017
Merged

Fix autodifferentiation #16

merged 1 commit into from Aug 25, 2017

Conversation

devmotion
Copy link
Member

There were some bugs regarding autodifferentiation. This PR also improves results of domain callbacks that rely on a ManifoldProjection.

I had to remove f! from the definition of the Jacobian configuration and replace it with nothing, such that according to the documentation of ForwardDiff

the returned instance can be used with any target function. However, this will reduce ForwardDiff's ability to catch and prevent perturbation confusion (see JuliaDiff/ForwardDiff.jl#83).

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage increased (+8.9%) to 91.129% when pulling e4fe6e6 on devmotion:fix_autodiff into 70ae024 on JuliaDiffEq:master.

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #16 into master will increase coverage by 8.87%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   82.25%   91.12%   +8.87%     
==========================================
  Files           4        4              
  Lines         124      124              
==========================================
+ Hits          102      113      +11     
+ Misses         22       11      -11
Impacted Files Coverage Δ
src/manifold.jl 88.23% <66.66%> (+32.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ae024...e4fe6e6. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 6316547 into SciML:master Aug 25, 2017
@devmotion devmotion deleted the fix_autodiff branch August 25, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants