Finite difference branch (Calculus.jl replacement) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-valued callables
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
Coverage ? 43.58%
=========================================
Files ? 1
Lines ? 156
Branches ? 0
=========================================
Hits ? 68
Misses ? 88
Partials ? 0
Continue to review full report at Codecov.
|
|
Changes Unknown when pulling b76ba94 on finitediff into ** on master**. |
1 similar comment
|
Changes Unknown when pulling b76ba94 on finitediff into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the code is far from perfect (does not handle complex-valued functions, could use refactoring to get rid of some redundant code where possible, etc.), I think it's a functionally complete Calculus.jl replacement that vastly outdoes it in performance (particularly for DiffEq wrapper types). Accordingly, I think it might be ready for a first release unless you see anything you don't like.