Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when x is a ndarray #77

Merged
merged 2 commits into from Nov 3, 2019
Merged

fix error when x is a ndarray #77

merged 2 commits into from Nov 3, 2019

Conversation

huanglangwen
Copy link
Contributor

@ChrisRackauckas
Copy link
Member

Can this get a test?

@coveralls
Copy link

coveralls commented Nov 3, 2019

Coverage Status

Coverage decreased (-7.2%) to 61.714% when pulling 778c332 on oop into 5441342 on master.

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #77 into master will increase coverage by 0.63%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   73.38%   74.02%   +0.63%     
==========================================
  Files           8        8              
  Lines         496      512      +16     
==========================================
+ Hits          364      379      +15     
- Misses        132      133       +1
Impacted Files Coverage Δ
src/jacobians.jl 89.93% <90%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5441342...778c332. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 2f52422 into master Nov 3, 2019
@ChrisRackauckas
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants