Fix ode_order_lowering pass and add stricter tests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODE order lowering introduces more dependent variables, thus, we have to update the `dvs` field in `DiffEqSystem`, after the order lowering pass.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 94.44% 94.49% +0.05%
==========================================
Files 11 11
Lines 324 327 +3
==========================================
+ Hits 306 309 +3
Misses 18 18
Continue to review full report at Codecov.
|
HarrisonGrodin
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
There are a few things I'd like to change about how we do ode_order_lowering overall, but those aren't strictly related to this PR - I've opened #115 to address those.
This looks good to merge otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODE order lowering introduces more dependent variables, thus, we have to update
the
dvsfield inDiffEqSystem, after the order lowering pass.