Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce potential for nontermination in Derivative #84

Merged
merged 2 commits into from Jan 12, 2019
Merged

Conversation

HarrisonGrodin
Copy link
Contributor

Re: #82.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #84 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage    89.7%   89.68%   -0.03%     
==========================================
  Files          11       11              
  Lines         408      407       -1     
==========================================
- Hits          366      365       -1     
  Misses         42       42
Impacted Files Coverage Δ
src/differentials.jl 93.02% <100%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0097578...50faac0. Read the comment docs.

@HarrisonGrodin
Copy link
Contributor Author

Also, do we want to expose the Derivative function, or should it be kept internal (only for method extension)?

@ChrisRackauckas
Copy link
Member

Also, do we want to expose the Derivative function, or should it be kept internal (only for method extension)?

It should probably just be kept as an internal detail.

@ChrisRackauckas ChrisRackauckas merged commit d1a6adc into master Jan 12, 2019
@ChrisRackauckas ChrisRackauckas deleted the hg/fix/82 branch January 12, 2019 11:18
jpfairbanks added a commit to jpfairbanks/ModelingToolkit.jl that referenced this pull request Jan 15, 2019
ChrisRackauckas added a commit that referenced this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants