Refactor system storage #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 93.53% 93.16% -0.37%
==========================================
Files 11 11
Lines 371 366 -5
==========================================
- Hits 347 341 -6
- Misses 24 25 +1
Continue to review full report at Codecov.
|
|
Build failure unrelated (re: JuliaLang/MbedTLS.jl#193). |
HarrisonGrodin
force-pushed
the
hg/refactor/systems
branch
from
0c3f4fd
to
259a46f
Compare
| @@ -46,7 +46,7 @@ Each operation builds an `Operation` type, and thus `eqs` is an array of | |||
| analyzed by other programs. We can turn this into a `DiffEqSystem` via: | |||
|
|
|||
| ```julia | |||
| de = DiffEqSystem(eqs,[t],[x,y,z],[σ,ρ,β]) | |||
| de = DiffEqSystem(eqs,t,[x,y,z],[σ,ρ,β]) | |||
There was a problem hiding this comment.
Rename this ODE system, since something like a PDE system would have two independent variables.
ChrisRackauckas
approved these changes
Feb 2, 2019
|
We can always rename later. I'm not convinced that splitting out ODEs to their own form is actually going to not lead to a ton of code duplication, but for now it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.