Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct order of evaluation #4

Merged
merged 1 commit into from Aug 2, 2017
Merged

Correct order of evaluation #4

merged 1 commit into from Aug 2, 2017

Conversation

devmotion
Copy link
Member

Fixes #3.

ChrisRackauckas
ChrisRackauckas approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM.

@devmotion devmotion mentioned this pull request Aug 2, 2017
Closed
@devmotion devmotion merged commit bd28aba into SciML:master Aug 2, 2017
@devmotion devmotion deleted the eval_order branch August 2, 2017 23:32
@ChrisRackauckas
Copy link
Member

I'm just gonna release a patch right now because I am sure this won't change very soon.

@coveralls
Copy link

coveralls commented Aug 2, 2017 •
edited

Coverage Status

Coverage remained the same at 97.727% when pulling cc0402b on devmotion:eval_order into 748243b on JuliaDiffEq:master.

@codecov
Copy link

codecov bot commented Aug 2, 2017 •
edited

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files           1        1           
  Lines          44       44           
=======================================
  Hits           43       43           
  Misses          1        1
Impacted Files Coverage Δ
src/MuladdMacro.jl 97.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748243b...cc0402b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devmotion @ChrisRackauckas @coveralls