Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MMUT #1081

Merged
merged 8 commits into from
Mar 16, 2020
Merged

[WIP] MMUT #1081

merged 8 commits into from
Mar 16, 2020

Conversation

Biswajitghosh98
Copy link
Contributor

Implemented Leapfrog Magnus as mentioned in the issue #1062

@Biswajitghosh98 Biswajitghosh98 mentioned this pull request Mar 16, 2020
Closed
@Biswajitghosh98 Biswajitghosh98 changed the title MMUT [WIP] MMUT Mar 16, 2020
@coveralls
Copy link

coveralls commented Mar 16, 2020 •
edited

Coverage Status

Coverage decreased (-0.9%) to 86.32% when pulling 150697f on Biswajitghosh98:MMUT into 47f0558 on JuliaDiffEq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 82.906% when pulling 0e0d47f on Biswajitghosh98:MMUT into 47f0558 on JuliaDiffEq:master.

@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited

Codecov Report

Merging #1081 into master will increase coverage by 2.07%.
The diff coverage is 77.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1081      +/-   ##
=========================================
+ Coverage   75.33%   77.4%   +2.07%     
=========================================
  Files          95      95              
  Lines       31429   31459      +30     
=========================================
+ Hits        23676   24350     +674     
+ Misses       7753    7109     -644
Impacted Files Coverage Δ
src/OrdinaryDiffEq.jl 100% <ø> (ø) ⬆️
src/algorithms.jl 84.64% <ø> (+0.82%) ⬆️
src/alg_utils.jl 27.6% <0%> (+2.71%) ⬆️
src/caches/linear_caches.jl 81.48% <80%> (-0.34%) ⬇️
src/perform_step/linear_perform_step.jl 59.29% <81.81%> (-5.23%) ⬇️
src/caches/kencarp_kvaerno_caches.jl 92.3% <0%> (ø) ⬆️
src/dense/interpolants.jl 96.79% <0%> (+0.23%) ⬆️
src/tableaus/low_order_rk_tableaus.jl 32.27% <0%> (+0.25%) ⬆️
src/perform_step/sdirk_perform_step.jl 79.44% <0%> (+0.37%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdd222...150697f. Read the comment docs.

ChrisRackauckas
ChrisRackauckas reviewed Mar 16, 2020
View reviewed changes
src/OrdinaryDiffEq.jl Outdated
@@ -198,7 +198,7 @@ module OrdinaryDiffEq
Kvaerno3, KenCarp3, Cash4, Hairer4, Hairer42, SSPSDIRK2, Kvaerno4,
Kvaerno5, KenCarp4, KenCarp5, ESDIRK54I8L2SA

export MagnusMidpoint, LinearExponential
export MagnusMidpoint, LinearExponential, MMUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it MagnusLeapfrog: much more common.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisRackauckas Done !

@ChrisRackauckas
Copy link
Member

Failure unrelated

@ChrisRackauckas ChrisRackauckas merged commit f00f6ad into SciML:master Mar 16, 2020
@Biswajitghosh98
Copy link
Contributor Author

Fixes #1062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Biswajitghosh98 @coveralls @ChrisRackauckas