Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESERK4 #737

Merged
merged 11 commits into from Jun 30, 2019
Merged

ESERK4 #737

merged 11 commits into from Jun 30, 2019

Conversation

deeepeshthakur
Copy link
Contributor

@ChrisRackauckas ESERK4 from Extrapolated Stabilized Explicit Runge–Kutta Methods. It's Passing the tests, But the compilation time is more than usual.

using Plots
probArr = Vector{ODEProblem}(undef, 2)
probArr[1] = prob_ode_linear
probArr[2] = prob_ode_2Dlinear
dts = 1 .//2 .^(8:-1:4)
testTol = 0.1
sim = test_convergence(dts,probArr[1],ESERK4())
@test sim.𝒪est[:l∞] ≈ 4 atol=testTol
plot(sim)

image

sim = test_convergence(dts,probArr[2],ESERK4())
@test sim.𝒪est[:l∞] ≈ 4 atol=testTol
plot(sim)

image

#2

@coveralls
Copy link

coveralls commented May 16, 2019

Coverage Status

Coverage increased (+6.6%) to 84.341% when pulling 5c2563a on deeepeshthakur:ESERK4 into 22e0af8 on JuliaDiffEq:master.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #737 into master will increase coverage by 0.04%.
The diff coverage is 89.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   80.07%   80.12%   +0.04%     
==========================================
  Files          88       88              
  Lines       28989    29134     +145     
==========================================
+ Hits        23214    23344     +130     
- Misses       5775     5790      +15
Impacted Files Coverage Δ
src/OrdinaryDiffEq.jl 100% <ø> (ø) ⬆️
src/tableaus/rkc_tableaus.jl 100% <ø> (ø) ⬆️
src/alg_utils.jl 32.54% <0%> (-0.08%) ⬇️
src/algorithms.jl 96.86% <100%> (+0.01%) ⬆️
src/caches/rkc_caches.jl 96.84% <100%> (+0.5%) ⬆️
src/rkc_utils.jl 75.58% <38.46%> (-3.31%) ⬇️
src/perform_step/rkc_perform_step.jl 87.08% <94.73%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e0af8...5c2563a. Read the comment docs.

@deeepeshthakur
Copy link
Contributor Author

@ChrisRackauckas All RKC test are working fine when I'm testing them locally but failing here.
Result when run locally

This is the error:

Power Iteration of Runge-Kutta-Chebyshev Tests: Error During Test at /home/travis/build/JuliaDiffEq/OrdinaryDiffEq.jl/test/ode/rkc_tests.jl:9
  Got exception outside of a @test
  TypeError: in new, expected NTuple{49,Int64}, got NTuple{49,Int64}

@deeepeshthakur
Copy link
Contributor Author

@ChrisRackauckas Travis error is because of Extrapolation methods and I fixed the type mismatch error. And ESERK4 is passing all tests now.

@ChrisRackauckas ChrisRackauckas merged commit f13d3c8 into SciML:master Jun 30, 2019
@deeepeshthakur deeepeshthakur deleted the ESERK4 branch June 30, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants