Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCK methods #740

Merged
merged 6 commits into from May 19, 2019
Merged

Fix ROCK methods #740

merged 6 commits into from May 19, 2019

Conversation

deeepeshthakur
Copy link
Contributor

@ChrisRackauckas

  1. Fixes constants for ROCK2 and ROCK4
  2. Fixes perform_step for ROCK2 and ROCK4
  3. Adds min_stage and max_stage functionality in ROCK methods
  4. Adds tests for min_stage. This also insures that the right constants are chosen.

@deeepeshthakur
Copy link
Contributor Author

@ChrisRackauckas
This could a weak proof that stage selection is working fine. You see after we introduce some minimum stages, the error goes down.

  1. ROCK2 1D linear
  2. ROCK2 2D linear
  3. ROCK4 1D linear
  4. ROCK4 2D linear

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #740 into master will increase coverage by 0.01%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   71.62%   71.63%   +0.01%     
==========================================
  Files          89       89              
  Lines       29012    29022      +10     
==========================================
+ Hits        20779    20791      +12     
+ Misses       8233     8231       -2
Impacted Files Coverage Δ
src/caches/rkc_caches.jl 96.59% <ø> (ø) ⬆️
src/tableaus/rkc_tableaus.jl 100% <ø> (ø) ⬆️
src/algorithms.jl 96.85% <100%> (+0.02%) ⬆️
src/perform_step/rkc_perform_step.jl 85.55% <100%> (+0.44%) ⬆️
src/rkc_utils.jl 78.48% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3247e0...f46af6c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.5%) to 69.174% when pulling f46af6c on deeepeshthakur:ROCKIMplementation into d3247e0 on JuliaDiffEq:master.

@ChrisRackauckas ChrisRackauckas merged commit c3551ae into SciML:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants