CleanUp ROCK Methods and Memory Usage ROCK4 #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeepeshthakur
commented
May 20, 2019
| uᵢ₋₃ = u + a₄₁*uᵢ₋₁ | ||
| u += B₁*uᵢ₋₁ | ||
| integrator.opts.adaptive && (tmp = B̂₁*uᵢ₋₁) | ||
| uᵢ₋₁ = u + (a₂₁ - B₁)*uᵢ₋₁ |
There was a problem hiding this comment.
@ChrisRackauckas This is addition subtraction of the same thing but the only way to avoid it is to add another array. Also both a21 and B1 are constants so I think doing this should not be an issue.
There was a problem hiding this comment.
yeah this should be fine.
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 71.63% 71.64% +<.01%
==========================================
Files 89 89
Lines 29022 29022
==========================================
+ Hits 20791 20792 +1
+ Misses 8231 8230 -1
Continue to review full report at Codecov.
|
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas
Reduces memory usage in
ROCK4.Makes the code more readable and Implementation style now resembles the paper more for both
ROCK2andROCK4Also makes one small correction in
perform_step