Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass matrix hotfix #93

Merged
merged 6 commits into from Jul 25, 2018
Merged

Mass matrix hotfix #93

merged 6 commits into from Jul 25, 2018

Conversation

MSeeker1340
Copy link
Contributor

Address changes in SciML/DiffEqBase.jl#126.

I think the SDEProblem and SDEFunction interface can still use some improvements though. It doesn't really make sense to repeat the g field in both the problem and the function --- one should be enough.

@ChrisRackauckas
Copy link
Member

I think the SDEProblem and SDEFunction interface can still use some improvements though. It doesn't really make sense to repeat the g field in both the problem and the function --- one should be enough.

Indeed. I just haven't worked through the whole thing yet.

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0dff9b9). Click here to learn what that means.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage          ?   90.45%           
=========================================
  Files             ?       34           
  Lines             ?     1394           
  Branches          ?        0           
=========================================
  Hits              ?     1261           
  Misses            ?      133           
  Partials          ?        0
Impacted Files Coverage Δ
src/caches/kencarp_caches.jl 100% <ø> (ø)
src/caches/basic_method_caches.jl 100% <ø> (ø)
src/perform_step/sdirk.jl 81.81% <0%> (ø)
src/perform_step/implicit_split_step.jl 58.33% <0%> (ø)
src/derivative_utils.jl 100% <100%> (ø)
src/algorithms.jl 100% <100%> (ø)
src/solve.jl 79.83% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dff9b9...068a508. Read the comment docs.

@ChrisRackauckas
Copy link
Member

Looks like there was some issues with the local testing setup so I got this from here. Thanks!

@ChrisRackauckas ChrisRackauckas merged commit 068a508 into SciML:master Jul 25, 2018
@MSeeker1340 MSeeker1340 deleted the mass-matrix branch July 25, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants