Fix Callbacks #233
Merged
Fix Callbacks #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Feb 19, 2020
YingboMa
reviewed
Feb 19, 2020
src/common_interface/solve.jl
Outdated
| @@ -62,6 +62,8 @@ function DiffEqBase.__init( | |||
|
|
|||
| progress && @logmsg(-1,progress_name,_id=_id = :Sundials,progress=0) | |||
|
|
|||
| uBottomEltype = recursive_bottom_eltype(prob.u0) | |||
There was a problem hiding this comment.
even better: we know it has to be Float64
There was a problem hiding this comment.
Lol let me redo this whole PR
|
Can we get a test? |
|
There are some issues with Sundials + VectorContinuousCallbacks. I will check this today |
|
Nope there wasn't any issue. It was just me being an idiot. The PR is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.