Added constructor for RadialBasis, still missing test #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Radials.jl
Outdated
| -'phi': radial basis of choice | ||
| -'q': number of polynomial elements | ||
| """ | ||
| function RadialBasis(new_value::Number,x::Array,y::Array,a::Number,b::Number,phi::Function,q::Int) |
There was a problem hiding this comment.
Put the constructor right next to the type. Also new_value shouldn't be here.
There was a problem hiding this comment.
Why new_value should not be there? It is needed for the prediction
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constructor for RadialBasis, still missing test.
I am wondering if I should use a struct containing both phi and q as input because these two elements are closely related.
Still debating if I should construct some example of radial basis, that's why I left the implementation commented.