Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1D expected improvement method, now working on ND #35

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

ludoro
Copy link
Contributor

@ludoro ludoro commented Jun 29, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #35 into master will decrease coverage by 44.48%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
- Coverage   94.17%   49.68%   -44.49%     
===========================================
  Files           5        5               
  Lines         412      481       +69     
===========================================
- Hits          388      239      -149     
- Misses         24      242      +218
Impacted Files Coverage Δ
src/Surrogates.jl 100% <ø> (ø) ⬆️
src/Optimization.jl 9.02% <82.75%> (-78.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a949542...7382fe4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #35 into master will decrease coverage by 44.48%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
- Coverage   94.17%   49.68%   -44.49%     
===========================================
  Files           5        5               
  Lines         412      481       +69     
===========================================
- Hits          388      239      -149     
- Misses         24      242      +218
Impacted Files Coverage Δ
src/Surrogates.jl 100% <ø> (ø) ⬆️
src/Optimization.jl 9.02% <82.75%> (-78.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a949542...7382fe4. Read the comment docs.

@ChrisRackauckas
Copy link
Member

looks good.

@ChrisRackauckas ChrisRackauckas merged commit 2e471f6 into master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants