Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to make deploying preview docs for a PR easier #1131

Closed
oxinabox opened this issue Sep 16, 2019 · 5 comments
Closed

Add feature to make deploying preview docs for a PR easier #1131

oxinabox opened this issue Sep 16, 2019 · 5 comments
Milestone

Comments

@oxinabox
Copy link
Contributor

@fredrikekre has code that works
fredrikekre/Literate.jl#75

But it is pretty evil,
It would be nicer if we could just say call deploydocs
with the right arguments.

@oxinabox
Copy link
Contributor Author

Other issues:

JuliaDiff/ChainRules.jl#105 (comment)

@oxinabox
Copy link
Contributor Author

It would be also good if we could have a way to have a comment automatically go back to the PR saying "Your docs have built, new URL is at"

@fredrikekre
Copy link
Member

PR doesn't show up in version selector from stable/dev versions because the current hack doesn't update the versions.jl, though I might argue that is actually a feature.

Yea, hence the delete_method for that, didn't want "real" docs to be affected in any way.

@oxinabox
Copy link
Contributor Author

seems legit, if we has it as a built in option, we might want to make it a kwarg:
"Include preview in main listing" or something?

@fredrikekre
Copy link
Member

push_preview to deploydocs now implemented. Pushes to .../previews/PR$(NUM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants