Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop warning for mailto: links #1472

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Stop warning for mailto: links #1472

merged 3 commits into from
Nov 15, 2020

Conversation

friggog
Copy link
Contributor

@friggog friggog commented Nov 10, 2020

Previously mailto: links got treated as a local link so triggered a warning

@mortenpi mortenpi added this to the 0.26.0 milestone Nov 10, 2020
@mortenpi
Copy link
Member

LGTM, although I am wondering if we should do this check already in isabsurl:

"""
isabsurl(url)
Checks whether `url` is an absolute URL (as opposed to a relative one).
"""
isabsurl(url) = occursin(ABSURL_REGEX, url)
const ABSURL_REGEX = r"^[[:alpha:]+-.]+://"

@friggog
Copy link
Contributor Author

friggog commented Nov 12, 2020

I'm not certain I'd count a mailto link as an absolute url - not sure exactly what the definition is but to me it seems to complicate the semantics of the isabsurl function?

Easy change if you'd prefer to roll it in vs what is there now

@mortenpi mortenpi modified the milestones: 0.26.0, 0.25.4 Nov 15, 2020
@mortenpi
Copy link
Member

That's fair, I was similarly unsure. For what it's worth, I think technically they are (e.g. IsURL considers them to be absolute), but we can leave figuring that out for another day. Thanks for the PR!

@mortenpi mortenpi merged commit 497d7d1 into JuliaDocs:master Nov 15, 2020
mortenpi pushed a commit that referenced this pull request Nov 15, 2020
@mortenpi mortenpi mentioned this pull request Nov 15, 2020
@friggog friggog deleted the mailto branch November 16, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants