Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rna function from using LightGraphs.jl to using Graphs.jl #124

Closed
Datseris opened this issue Dec 4, 2021 · 1 comment
Closed

Update rna function from using LightGraphs.jl to using Graphs.jl #124

Datseris opened this issue Dec 4, 2021 · 1 comment
Labels
breaking bug good first issue An easy issue, suitable for new contributors. high priority This needs to be done soon!

Comments

@Datseris
Copy link
Member

Datseris commented Dec 4, 2021

Super straightforward, kinda mandatory, but I don't think we should count it as a breaking change. We're literally changing the LightGraphs name with Graphs.jl. See https://discourse.julialang.org/t/lightgraphs-jl-transition/69526 for more details.
@Datseris Datseris added bug good first issue An easy issue, suitable for new contributors. breaking labels Dec 4, 2021
@Datseris Datseris added the high priority This needs to be done soon! label Dec 19, 2021
@Datseris
Copy link
Member Author

Furthermore when running the test suite we now get the following deprecation:

┌ Warning: Infinite path length detected for vertex 10
└ @ LightGraphs C:\Users\datse\.julia\packages\LightGraphs\IgJif\src\distance.jl:74

So might be a good idea if this remains after the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking bug good first issue An easy issue, suitable for new contributors. high priority This needs to be done soon!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Datseris