update for cstparser changes #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Jan 13, 2018
src/languageserverinstance.jl
Outdated
| @@ -29,6 +29,8 @@ function send(message, server) | |||
| end | |||
|
|
|||
| function Base.run(server::LanguageServerInstance) | |||
| io = open("/home/zac/jls.log", "a") | |||
There was a problem hiding this comment.
I'll pull this change as we've got telemetry and potentially an upstream fix for the self-deleting logs
davidanthoff
approved these changes
Jan 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 38.67% 38.89% +0.21%
==========================================
Files 30 30
Lines 1872 1864 -8
==========================================
+ Hits 724 725 +1
+ Misses 1148 1139 -9
Continue to review full report at Codecov.
|
|
Tests pass, there's a backlog on travis that stopped them from completing though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for changes to CSTParser interface