Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b:undo_ftplugin should not reset indentation settings #315

Closed
kyllingstad opened this issue Apr 4, 2024 · 4 comments
Closed

b:undo_ftplugin should not reset indentation settings #315

kyllingstad opened this issue Apr 4, 2024 · 4 comments

Comments

@kyllingstad
Copy link

kyllingstad commented Apr 4, 2024

The b:undo_ftplugin variable defined in ftplugin/julia.vim resets indentation options like indentexpr. It shouldn't, because that script does not set those options, and therefore its undo action should not reset them.

These options should only be reset by the actions of b:undo_indent defined in indent/julia.vim (and they correctly are).

@kyllingstad
Copy link
Author

I edited the description of this issue because it turned out that much of what I described was specific to my particular .vimrc setup. But the main issue still stands, I think.

@dkearns
Copy link
Contributor

dkearns commented Apr 5, 2024

It looks like this was added to b:undo_ftplugin in 7b71f09 before the author was probably aware of b:undo_indent.

@carlobaldassi
Copy link
Contributor

Fixed in e36d07f
(sorry about the wrong issue ref in the commit message, a cut&paste went wrong)
Thanks for reporting this

@chrisbra
Copy link

chrisbra commented May 7, 2024

@carlobaldassi can you send an update to Vim so we can fix vim/vim#14419 there as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants