Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better test coverage, use same template for running tests #3

Merged
merged 9 commits into from Feb 15, 2018
Merged

Better test coverage, use same template for running tests #3

merged 9 commits into from Feb 15, 2018

Conversation

jtveiten
Copy link
Collaborator

I've updated the tests to adhere more to the approach in Base. Also added a bit more coverage with tests along the y axis.

@coveralls
Copy link

coveralls commented Jan 31, 2018 •
edited

Coverage Status

Coverage increased (+5.1%) to 100.0% when pulling 61ce067 on jtveiten:master into ce7fffb on JuliaFEM:master.

@ahojukka5
Copy link
Owner

https://coveralls.io/builds/15313309/source?filename=src%2FFEMTruss.jl

You get quite easily coverage to 100 % just by calling the functions shown in red in report.

@jtveiten
Copy link
Collaborator Author

jtveiten commented Feb 1, 2018 •
edited

I got into a problem when calling get_formulation_type(p1)
It comes up with an undefined variable when called. Is there an issue in Base, or am I doing something wrong?
Thus I just checked in the first function check

@ahojukka5 I've been trying to get the method get_formulation_type to work properly.
I've tried different alternatives, but I can't see what the problem is.
Must be something in the signature?
Test threw an exception of type UndefVarError
Expression: get_formulation_type(p1)
UndefVarError: get_formulation_type not defined

jtveiten and others added 6 commits February 10, 2018 12:30
@jtveiten
Add test file for truss systems
d92cba7
@jtveiten
Forgot license header again
45467f0
@ahojukka5
Fix test
2c770ee 
`get_formulation_type` is not exported from FEMBase
@ahojukka5
Implement nodal boundary conditions
e3e31fc 
* Using element `Poi1`, one can use field `nodal force i` where `i` is a
  dof number, to set nodal force / concentrated load (CLOAD in Abaqus).
* Using element `Poi1`, one can use field `fixed displacement i`, where
  `i` is a dof number, to fix displacement in some node.
* Wrote a test to test nodal elements + 2 truss test.
@jtveiten
Merge pull request #1 from ahojukka5/master
98bd054 
Implement nodal boundary conditions
@jtveiten
Added checks for test, missing element and support force checks
61ce067
@ahojukka5
Copy link
Owner

Looks good to me, maybe we now merge this now and then plan if some changes is needed.

@ahojukka5 ahojukka5 merged commit c337df5 into ahojukka5:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojukka5 ahojukka5 Awaiting requested review from ahojukka5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtveiten @coveralls @ahojukka5