Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split units to a supplemental unitful package #91

Closed
yakir12 opened this issue Dec 15, 2017 · 2 comments
Closed

Split units to a supplemental unitful package #91

yakir12 opened this issue Dec 15, 2017 · 2 comments

Comments

@yakir12
Copy link

yakir12 commented Dec 15, 2017

This is just a suggestion, but would it make sense for you to split the functionality of this package into the "units" part and the "everything else" part?

If so, you could write the units part as a supplemental units package for Unitful.jl. This way, users that want to use just the monitory units could do so without importing a bunch of other things, and developers that want to work on the "everything else" part can do so more easily. It will help keep the functionalities of the different packages more clear and modular.

Again, I might be totally wrong here..

@TotalVerb
Copy link
Member

TotalVerb commented Dec 18, 2017

This is a good idea and probably can be semi-easily done too. In fact, the units part is already semi-isolated in https://github.com/JuliaFinance/Currencies.jl/blob/master/src/CurrenciesBase/monetary.jl, and can probably be split off, and the other functionality is already organized into submodules: https://github.com/JuliaFinance/Currencies.jl/tree/master/src. So this should not be, I think, a particularly disruptive undertaking.

Unfortunately I don't have time in the near future to maintain this package. If you would be willing to start on this work, we can add you to the organization and I'll be happy to answer any questions you may have.

@yakir12
Copy link
Author

yakir12 commented Dec 19, 2017

Neat!

Unfortunately, I too don't have the time nor the need to do this right now. Maybe you can put a label or two on this issue (e.g. enhancement, good first issue, and help wanted). A shout-out on Discourse won't hurt either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants