Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on number of iterations are sensitive to randn #37

Closed
rfourquet opened this issue Apr 24, 2020 · 4 comments · Fixed by #38
Closed

Tests on number of iterations are sensitive to randn #37

rfourquet opened this issue Apr 24, 2020 · 4 comments · Fixed by #38

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf. https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/ProximalAlgorithms/1.5.0-DEV-71a4a114c2.log

@nantonel
Copy link
Collaborator

@lostella I remember we decided to relax the tests on the number of iterations (I couldn't find the issue though).

Looks like they were not relaxed enough? The order look very similar, so it is definitively that:

[...]
  Expression: it_dys <= 1900
   Evaluated: 2363 <= 1900
[...]
  Expression: it_dys <= 2600
   Evaluated: 2877 <= 2600
[...]
  Expression: it_afba <= maxit
   Evaluated: 530 <= 500

I wonder if these tests could be replaced by something more robust...

@lostella
Copy link
Member

@nantonel I think at this point it would be great to replace these tests with some fixed problem, instead of randomly generated...

@nantonel
Copy link
Collaborator

I see that most calls to randn don't use a fixed random generator likerandn(rng, ComplexF32, (2, 3)).

That should avoid pasting numbers like in the LBFGS tests unless random generators are changed which I don't think happen very often.

@nantonel nantonel changed the title possible test failure in upcoming Julia version 1.5 Tests on number of iterations are sensitive to randn Apr 28, 2020
@lostella
Copy link
Member

lostella commented May 2, 2020

@nantonel #38 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants