Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt.ndims errors for Symmetric CuMatrix #74

Closed
avik-pal opened this issue Dec 7, 2023 · 2 comments
Closed

Adapt.ndims errors for Symmetric CuMatrix #74

avik-pal opened this issue Dec 7, 2023 · 2 comments

Comments

@avik-pal
Copy link

avik-pal commented Dec 7, 2023

julia> using CUDA, LinearAlgebra, Adapt

julia> A = Symmetric(cu(Hermitian(rand(4, 4) + I)))
4×4 Symmetric{Float32, CuArray{Float32, 2, CUDA.Mem.DeviceBuffer}}:
 1.04768   0.762224  0.417242   0.939324
 0.762224  1.32384   0.885197   0.406453
 0.417242  0.885197  1.21459    0.0398361
 0.939324  0.406453  0.0398361  1.74983

julia> Adapt.ndims(typeof(A))
ERROR: UndefVarError: `N` not defined
Stacktrace:
 [1] ndims(::Type{Symmetric{Float32, CuArray{Float32, 2, CUDA.Mem.DeviceBuffer}}})
   @ Adapt /mnt/julia/packages/Adapt/yYvku/src/wrappers.jl:132
 [2] top-level scope
   @ REPL[17]:1
 [3] top-level scope
   @ /mnt/julia/packages/Infiltrator/LtFao/src/Infiltrator.jl:726
 [4] top-level scope
   @ /mnt/julia/packages/CUDA/YIj5X/src/initialization.jl:208
@avik-pal
Copy link
Author

avik-pal commented Dec 7, 2023

Actually, this is fixed on the master. @maleadt can we tag a patch release of master

@maleadt
Copy link
Member

maleadt commented Dec 8, 2023

Fixed by #73. Let's tag a release.

@maleadt maleadt closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants