Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dims support for softmax #226

Closed
CarloLucibello opened this issue Jun 17, 2020 · 0 comments · Fixed by #523
Closed

dims support for softmax #226

CarloLucibello opened this issue Jun 17, 2020 · 0 comments · Fixed by #523
Labels
cuda array Stuff about CuArray. enhancement New feature or request

Comments

@CarloLucibello
Copy link
Contributor

NNlib's softmax now supports a dims keyword argument, so we should support it here as well.
Not any dims is supported by cudnn, so we may have to add a native implementation (#175). This unless we consider https://github.com/FluxML/NNlib.jl/blob/0d16973bab1260de045c1599ec3d12e5adac1d70/src/softmax.jl#L28 as an acceptable fallback for arbitrary dims, in which case we can close this issue
@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels Jun 17, 2020
@denizyuret denizyuret linked a pull request Dec 11, 2020 that will close this issue
New high level interface for cuDNN #523
Merged
25 tasks
@norci norci mentioned this issue Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New high level interface for cuDNN denizyuret/CUDA.jl
2 participants
@maleadt @CarloLucibello