Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel as kwarg or part of struct #39

Closed
willtebbutt opened this issue Jan 12, 2023 · 1 comment
Closed

kernel as kwarg or part of struct #39

willtebbutt opened this issue Jan 12, 2023 · 1 comment

Comments

@willtebbutt
Copy link
Member

willtebbutt commented Jan 12, 2023 •
edited
Loading

There appear to be two ways to pass a kernel to inducingpoints, either as a field of alg or as a kwarg to inducingpoints. Should we choose a single canonical way to do this?
@theogf
Copy link
Member

theogf commented Jan 12, 2023

Ups you're right. I would be of the opinion that it should always be a kwarg but StdDPP and kDPP don't respect that...

@theogf theogf mentioned this issue Jan 18, 2023
Merged
@theogf theogf closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willtebbutt @theogf