Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Aqua.jl #104

Open
rafaqz opened this issue Apr 12, 2024 · 1 comment
Open

Use Aqua.jl #104

rafaqz opened this issue Apr 12, 2024 · 1 comment

Comments

@rafaqz
Copy link
Member

rafaqz commented Apr 12, 2024 •
edited

I just noticed we have ambiguities in crosses and centroid.

I will be a little annoying to add Aqua because GeometryBasics.jl also has ambiguties and Aqua catches them.

(We also have unbound args and stae deps so its worth adding anyway)
@asinghvi17
Copy link
Member

Agreed, though we could always make it an optional check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @asinghvi17