Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of .dbf in test cases #80

Open
joshday opened this issue Jan 19, 2023 · 4 comments
Open

Lack of .dbf in test cases #80

joshday opened this issue Jan 19, 2023 · 4 comments

Comments

@joshday
Copy link
Contributor

joshday commented Jan 19, 2023

I just realized all but one of the cases in test/shapelib_testcases do not have a .dbf file. Given .dbf is mandatory according to the ESRI spec, we should add those.

In my quick search of http://shapelib.maptools.org/ I didn't see where those test cases are taken from.

@rafaqz
Copy link
Member

rafaqz commented Jan 19, 2023

It may be so long ago they are gone now. @yeesian do you remember the source of the test cases here?

@yeesian
Copy link
Member

yeesian commented Jan 20, 2023

Yeah sorry I don't fully remember what I did back then to generate them by now. A search on google turned this up: https://github.com/OSGeo/shapelib/blob/6189dbd83ba2382fe0ebbc8f2308e582832c93fa/shptest.c#L238-L275

From what I read in /test/shapelib_testcases/readme.txt, I think I generated them from running shptest.c in http://download.osgeo.org/shapelib/shapelib-1.3.0.tar.gz (archive of the other versions at http://download.osgeo.org/shapelib/).

@yeesian
Copy link
Member

yeesian commented Jan 20, 2023

See also: OSGeo/shapelib#15

@yeesian
Copy link
Member

yeesian commented Jan 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants