Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup terminology in docs #44

Closed
DanielVandH opened this issue Apr 16, 2023 · 1 comment
Closed

Cleanup terminology in docs #44

DanielVandH opened this issue Apr 16, 2023 · 1 comment

Comments

@DanielVandH
Copy link
Member

I believe I've been a bit careless in some places with how I use the terms edges / segments and points / vertices. I should clean this up at some point, so that:

  • edges are simply pairs (u, v) in the triangulation, but
  • segments are the constrained edges.
    In this way, boundary edge might just refer to an edge that happens to be on the boundary, while a boundary segment should refer to a constrained edge appearing on the boundary. Similarly,
  • points are the actual coordinates p[i] = (x[i], y[i]),
  • while vertices are the references to the point, i.e. i
    Similarly, wherever I use BoundaryIndex it should probably just be GhostVertex or GhostIndex.
@DanielVandH DanielVandH mentioned this issue Jun 16, 2023
7 tasks
@DanielVandH
Copy link
Member Author

Closing this as it is mentioned already now in #63 and is already in progress in the new-docs branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant