Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update a couple of docstrings, fix colorbutton and add to example #55

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

jwahlstrand
Copy link
Collaborator

This fixes a couple of docstrings that I had overlooked before, and also gets colorbutton working with Gtk4.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Merging #55 (ad58aa1) into master (46607bb) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   94.50%   94.58%   +0.08%     
==========================================
  Files           6        6              
  Lines        1091     1089       -2     
==========================================
- Hits         1031     1030       -1     
+ Misses         60       59       -1     
Files Changed Coverage Δ
src/graphics_interaction.jl 94.77% <ø> (ø)
src/rubberband.jl 96.59% <ø> (ø)
src/widgets.jl 93.12% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/rubberband.jl Outdated Show resolved Hide resolved
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@jwahlstrand jwahlstrand merged commit e12ad63 into master Sep 17, 2023
17 checks passed
@jwahlstrand jwahlstrand deleted the jw/new-version branch October 15, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants