Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate Julia->browser requests #323

Open
twavv opened this issue Jul 23, 2019 · 3 comments
Open

Reevaluate Julia->browser requests #323

twavv opened this issue Jul 23, 2019 · 3 comments
Labels
Milestone

Comments

@twavv
Copy link
Member

twavv commented Jul 23, 2019

A while ago I added the ability to send a request from Julia to the browser and expect a response. This doesn't really make sense because we assume that there may be many frontends connected.

We should either wait for all connections to respond and return an array of responses or take the first (this should be configurable and maybe default to throwing an error if more than one client is connected).

Or just remove these kinds of requests altogether (that does remove the ability to issue evaljs commands, but that's already supported in Blink and is impossible in Jupyter). We'd only lose the functionality for Mux essentially. But we should probably do the first one.

@twavv twavv added the proposal label Jul 23, 2019
@twavv twavv added this to the v0.9.0 milestone Aug 1, 2019
@shashi
Copy link
Member

shashi commented Aug 8, 2019

So you're sending these messages to a "scope" right? That's not impossible in Jupyter?

@shashi
Copy link
Member

shashi commented Aug 8, 2019

evaljs takes scope as an argument and gives you the scope JS object in scope variable or this (i don't remember which one).

@twavv
Copy link
Member Author

twavv commented Aug 8, 2019

You can send messages to Jupyter you just can't block while you wait for a response.

@twavv twavv mentioned this issue Dec 21, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants