Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@get! deprecation warning #426

Closed
kcajf opened this issue Aug 3, 2020 · 5 comments
Closed

@get! deprecation warning #426

kcajf opened this issue Aug 3, 2020 · 5 comments

Comments

@kcajf
Copy link

kcajf commented Aug 3, 2020

┌ Warning: `@get!(dict, key, default)` at /home/xxx/.julia/packages/WebIO/nTMDV/src/scope.jl:160 is deprecated, use `get!(()->default, dict, key)` instead.
└ @ Base deprecated.jl:204
┌ Warning: `@get!(dict, key, default)` at /home/xxx/.julia/packages/WebIO/nTMDV/src/scope.jl:357 is deprecated, use `get!(()->default, dict, key)` instead.
└ @ Base deprecated.jl:204

Seems like this has been deprecated in 1.5?

@twavv
Copy link
Member

twavv commented Aug 3, 2020

Yep. It's been silently discouraged for a while. This should be an easy fix.

@rasmushenningsson
Copy link
Contributor

I've made a pull request #428 for this.

@PetrKryslUCSD
Copy link

I am on 0.8.14, I look at the code and it seems to have been fixed, yet I still see these warnings?

@rasmushenningsson
Copy link
Contributor

I am on 0.8.14, I look at the code and it seems to have been fixed, yet I still see these warnings?

The fix is only on the master branch so far. It will be fixed for everyone when 0.8.15 is released.

@rasmushenningsson
Copy link
Contributor

This issue can be closed now that a new version has been released.

@twavv twavv closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants