Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observables 0.4 #455

Closed
Datseris opened this issue May 21, 2021 · 9 comments
Closed

Observables 0.4 #455

Datseris opened this issue May 21, 2021 · 9 comments

Comments

@Datseris
Copy link

Hi, can you please tag a patch release that bumps observables compatibility to 0.4? There wasn't any major breaking change. However, with your current Project.toml it is not possible to use Atom and Makie in the same environment...

@hhaensel
Copy link

Just realised that there is already a PR #456

@hhaensel
Copy link

I think this can be closed as the above PR is merged.

@Datseris
Copy link
Author

Did you tag a new version? Please close it when a new version is tagged.

@Datseris Datseris reopened this Jun 15, 2021
@jkrimmer
Copy link

Since in Observables 0.4 the function Observables.setexcludinghandlersinterface has been replaced by Observables.setexcludinghandlers!, the function set_nosync in scope.jl has to be adjusted as follows:

function set_nosync(ob, val)
    Observables.setexcludinghandlers!(ob, val)
end

In doing so, however, the compatibility with older releases of Observables is lost.

@hhaensel
Copy link

Why not checking for the existence of setexcludinghandlers!, e.g.

function set_nosync(ob, val)
    if isdefined(Observables, :setexcludinghandlers!)
        Observables.setexcludinghandlers!(ob, val)
    else
        Observables.setexcludinghandlers(ob, val, x -> !(x isa SyncCallback))
    end
end

@Datseris
Copy link
Author

In doing so, however, the compatibility with older releases of Observables is lost.

Just tag 0.9 to signal a breaking release, given that neither of these packages is in 1.0 and when observables went from 0.3 to 0.4 it signalled a breaking release as well.

@pdeffebach
Copy link

Bumping this, I am running into a compatibility issue here, would be great to get a new release, even with a clunky if...else block.

@hhaensel
Copy link

It's good practice to include such a compatibility version as minor change and then publish a breaking release without it.

@galran
Copy link

galran commented Jul 30, 2021

bump. this is causing compatibility issues with the new WGLMakie - any chance of an update soon?

@twavv twavv closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants