Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XYZ representation #30

Open
rennis250 opened this issue Feb 26, 2016 · 5 comments
Open

XYZ representation #30

rennis250 opened this issue Feb 26, 2016 · 5 comments
Labels
downstream Colors.jl, ColorVectorSpace.jl, etc. wontfix

Comments

@rennis250
Copy link

My previous comment was removed after reading a bit on the sRGB space.

We should add some documentation on the meaning of the scaled XYZ values and their relation to the sRGB representation that this package uses. The normalization of each component to D65 isn't standard in any of the color labs that I have worked in, for instance, causing some initial confusion for me.

I might have a chance to do it a bit later today.

Best,
Rob

@rennis250
Copy link
Author

Also, I would argue that the color type's fields should be labeled as X, Y, and Z, not x, y, and z.

@timholy
Copy link
Member

timholy commented Feb 26, 2016

It is a little confusing that we call this RGB but it's really sRGB. Not quite sure what to do about that.

@rennis250
Copy link
Author

Yes, if we tried to generalize on the RGB concept, then it would be appropriate to also include at least some of the other variants: https://en.wikipedia.org/wiki/RGB_color_space#Specifications

Perhaps we could make an RGB type that by default is the sRGB space (possibly the more common variant that one expects) and which could be optionally parameterized to implement the other variants? That could become a bit messy with respect to code, though... I'll need some sleep before I can think about it better.

I can start a separate issue to centralize the RGB discussion.

@kimikage
Copy link
Collaborator

@kimikage
Copy link
Collaborator

I do not fully understand the arguments of this issue, but I will update the README.md with ColorTypes v0.12 and then close this issue.
In other words, for now, I don't plan to change the XYZ's fields from x, y, and z. Also, metadata such as color gamut will be handled in higher level packages than ColorTypes.

@kimikage kimikage added wontfix downstream Colors.jl, ColorVectorSpace.jl, etc. labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream Colors.jl, ColorVectorSpace.jl, etc. wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants