Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to handle certain position related attributes #38

Open
Binary-Eater opened this issue Dec 25, 2021 · 5 comments
Open

Does not seem to handle certain position related attributes #38

Binary-Eater opened this issue Dec 25, 2021 · 5 comments

Comments

@Binary-Eater
Copy link

Examples include attributes like rankdir.

Versions of involved components used

  • Julia v1.6.3
  • GraphViz.jl v0.2.0
  • IJulia v1.23.2

Snippet for replicating the problem.

digraph graphname {
rankdir="BT";
overlap=false;
     a [shape="box",URL="https://www.google.com",label="Game",target="_blank"];
     b [shape="box",URL="https://www.google.com"];
     a -> b [minlen=10,taillabel = "taillabel"];
 }

What is seen in the local jupyter notebook

251221151818

What is see when using graphviz to generate a PNG from the same dot snippet

test

@vincent-picaud
Copy link

First of all, thank you for this package!

I also observe that there is a problem with rankdir.

digraph so 
{
   rankdir = LR;
   A -> B -> C -> D;
}

Does not work as expected (at least under Pluto)

Expected result:
image

Result under pluto.jl:
image

@abelsiqueira
Copy link

Same here. Could it be the version of graphviz?

@SebastianCallh
Copy link

Hi! I also experience this issue in Pluto with GraphViz 7.0.2. Does anyone find a way to solve this or diagnose where the issue comes from?

@abelsiqueira
Copy link

I have created a pull request that should fix this. Can you check with ] add https://github.com/abelsiqueira/GraphViz.jl#38-add-engine-attribute. I don't know how to do add custom pkgs on Pluto.

@vincent-picaud
Copy link

vincent-picaud commented Dec 2, 2022

@abelsiqueira
Thanks, I have tested it, on my side it works
pluto_test

To reproduce:

under bash
mkdir /tmp/test_pluto
Start Julia and ] to reach ** Pkg** mode

activate "/tmp/test_pluto"
add Pluto
add https://github.com/abelsiqueira/GraphViz.jl#38-add-engine-attribute

switch back to Julia mode
using Pluto; Pluto.run()

Then under Pluto

  • Cell 1
begin
	import Pkg
	Pkg.activate("/tmp/test_pluto")
	Pkg.status("GraphViz")
end
  • Cell 2
    using GraphViz
  • Cell 3
dot"""
digraph so 
{
   rankdir = LR;
   A -> B -> C -> D;
}
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants