Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible thread safety issue with active_devices #40

Open
frankier opened this issue Feb 11, 2022 · 1 comment
Open

Possible thread safety issue with active_devices #40

frankier opened this issue Feb 11, 2022 · 1 comment

Comments

@frankier
Copy link

The use of active_devices might not be thread safe if this library is used in more than one thread. Putting a new key in active_devices could cause it to be reallocated in one thread while another thread is reading which might cause undefined behaviour.

@Keno
Copy link
Contributor

Keno commented Feb 11, 2022

Yes, Julia didn't have threading when this package was written. We'll need to add some locks. That said, I'm not sure that the graphviz library itself is thread safe, so we'll want to investigate that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants