Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created alternative data loader function . #30

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

00krishna
Copy link
Collaborator

Created a new faster data loader function load_ipums_extract_v2(). This function is faster than the original load_ipums_extract() function. The signature is the same. To test the file, you can use code like.

    ddi = parse_ddi("testdata/cps_00157.xml")
    datafile = "testdata/cps_00157.dat"
    
    @btime df = load_ipums_extract(ddi, datafile)
    @btime df2 = load_ipums_extract_v2(ddi, datafile)

@00krishna
Copy link
Collaborator Author

READY FOR REVIEW.

Okay, I cleaned up a few additional things.

  • removed the old version of the loader functions.
  • removed unneeded dependency
  • removed unneeded test cases
  • formatted the ddi_parsers.jl to make it look better.

@TheCedarPrince
Copy link
Member

LGTM -- merging! Thanks so much @00krishna!

@TheCedarPrince TheCedarPrince merged commit faf2673 into main Jun 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants