-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP_POW
not defined
#536
Comments
The code path is only hit if the exponent is not an integer, so When implementing the procedure, I wanted to deal with general exponents initially but I abandoned this approach since it would only be allowed in very specific circumstances. However, I think just supporting rational numbers or floating point values should be easily feasible. |
Many thanks for responding so quickly. I have managed to make a minimum working example: using HomotopyContinuation
@var x
@var a b
vars = HomotopyContinuation.Variable[x]
para = HomotopyContinuation.Variable[a, b]
pol = x*sqrt((a^2 - b^2))
eq = Expression[pol]
sys = System(eq, variables = vars, parameters = para)
solve(sys, start_system=:total_degree, target_parameters=Number[0.99, 0.98]) To problem seems to be the |
Ah yes the square root is the problem, but this is actually exactly the case that I wanted to support in the first place. I will try to take a look soon :) |
I have tested out the new PR and it solves my original problem I experienced in HarmonicBalance.jl. Thank you! |
Happy to hear that :) Just tagged a new release (2.8.3) that contains the fix |
Running some code through HarmonicBalance.jl I bump into the error
UndefVarError: OP_POW not defined
with stacktrace:Indeed, investigating the source code in the model_kit module the definition of
OP_POW
is commented out. Is there a reason for that? ShouldOP_POW_INT
be used instead atmodel_kit\intermediate_representation.jl:391
?The text was updated successfully, but these errors were encountered: